John McCain was a good man and a good soldier
That said he was lost in space in a political sense. He was a tribune of the Pax Americana with its motto of 'make the world safe for democracy' which fell into complete disorder, hypocrisy and cynical self interest in the last half of the 20th Century. As such he was a free trader, cultural libertarian and aggressive proponent of extending America's military power in support of its interests.
He clashed on style, doctrine and national vision with Trump.. who was specifically excluded from attending the funeral by McCain. But frankly John McCain would have been a disaster if he had achieved his goal of becoming President.
However, RiP. He was an honourable, if somewhat befuddled, man.