Lt. Gen. McMaster is a practical soldier, an operational officer likely very skilled in tactics, organization and logistics.
I'm somewhat skeptical of appointments who have NO enemies in a political class as divided as that of America these days, which is sometimes is sign of a bureacrat who avoids taking stands on issues.. but i've heard otherwise as well.
What i don't see is a strong sense of the strategic vision that Lt. Gen. Flynn had, and who as an intelligence officer was adept at the synthesis of information and strategizing of issues. I can't help but think McMaster might be less of a resource than Flynn, although less difficult and controversial, no doubt.