Whether practicing Catholic or not, or Orthodox etc - Lent is a naturally adapted human cycle of cleansing, just as nature is doing right now with winds and rain, cleansing the earth of dead debris for the return of new growth.
The ancients pretty much all observed this rite and necessity for the body, mind and soul. Christianity adapted over top of pagan things like fasting etc.
So, on that note, fasting is something all people would do well do observe - or a sacrifice, food is normally the chosen item, as it is part of a cleansing human cycle.
But...giving up? hmm, is good to give up at least one thing and fast at least 3 times during lent, including Good Friday etc. Because the return to full way of eating or life is rewarding when a sacrifice has occured. In past, gave up coffee, salt, sugar, cookies etc. Giving up sugar was hard, because sugar in so many things, same with salt. I gave up salt shaker that time.
But it also cleanses the brain and soul in ways, depriving oneself, helps one feel grateful that they do have abundance in life.
As for the true lenten observance, also means to add something to ones repertoire of giving service or pay more attention to kindness, or acts of charity. I did not understand this growing up, but now I do.
So, for me, good question what to give up? and I almost forgot to contemplate this. Sometimes I go overboard, so doing something manageable is important.
1. Give up: french fries - my absolute weakness
2. Add more meditation and prayers to be kinder in my actions.
3. Clean my closets and give some stuff for act of charity.
O.k. that is 3 things.